http://devchat.tv/ruby-rogues/216-rr-code-review-culture-with-derek-prior
Talks about this talk talk-implementing-a-strong-code-review-culture
At 8:30 making an individual change - unit tests will help you ensure against regressions, but code reviews can help people give you insight about the system.
At 15 - pull request bombs
In a big pull request, sometimes you'll get no feedback at all.
35 how to introduce code review practice
51 practicing-the-process-and-the-overhead
podcast-rr-216-code-review-culture#practicing-the-process-and-the-overhead-quote1 SARON: One of the things that we started doing, I think, a few weeks ago is we started having these evening study sessions. So we have on Monday, we do Ruby. On Tuesday, we have JavaScript. On Thursday, we have Python. What we started doing is having team projects. The whole code review, pull request, team collaboration part is the focus of those projects. So JavaScript is doing like a Hangman game which is relatively simple but in the process of doing that, like we have a tally board and we're organizing our feature cards by priority. You have to get the thumbs up before you can merge in your pull request. And for a lot of people who've been mostly learning on their own and doing things there just by themselves, it's a really interesting opportunity to say, "Okay, now I have to know what a pull request is and how to name my branches and how to respond and how to communicate." We do that exactly for that reason. It's a huge skill. The thing there is just knowing how to code and good design patterns and that but then working on a team collaboratively to ship a product is a whole other skillset that I think is hard to pick up when you're learning on your own.
DAVID: That's fantastic, to pick a simple project and just put in all of the process and the overhead where yeah, you're basically just practicing the process in the overhead.
SARON: Exactly.
DAVID: The code itself is pretty simple. There's a really good motto that I heard about a year ago and it just keeps coming up over and over again. Of all places, I think it's from the Navy Seals but the motto is 'Go Slow to Go Smooth, Go Smooth to Go Fast'. And I really liked that motto of let's take some code where we're not panicking, we're not trying to get this shipped to keep the company from going bankrupt. All we're trying to do is just practice our process and make sure that everything is going out and coming back right in the way it needs to do. Once you start to get in the habit of write the code, push the commit, ask for the PR, wait for the LGTM, then merge the code. Yeah, now you start to get smooth and now you can start to go fast. podcast-rr-216-code-review-culture#practicing-the-process-and-the-overhead-quote1